Skip to content

fix: support package manager retries in VS Code promotion - W-23832274 - #170

Open
peternhale wants to merge 12 commits into
mainfrom
ph/W-23832274-pnpm-stable-promotion
Open

fix: support package manager retries in VS Code promotion - W-23832274#170
peternhale wants to merge 12 commits into
mainfrom
ph/W-23832274-pnpm-stable-promotion

Conversation

@peternhale

Copy link
Copy Markdown
Contributor

Summary

  • add package-manager inputs to VS Code manual and stable promotion workflows
  • use retry-backed, package-manager-agnostic dependency and lockfile installation for npm, pnpm, and Yarn
  • retain fixed stable-promotion quality checks and remove unneeded publish-job dependency installs

GUS

W-23832274: 4 Publish web VSIX to CBWeb internal marketplace

Validation

  • Parsed modified action and workflow YAML with Ruby YAML.load_file
  • Ran git diff --check

This enables package-manager-agnostic VS Code promotion workflows while preserving retry behavior for network-dependent installs.

@peternhale
peternhale requested a review from iowillhoit August 12, 2026 20:28
shell: bash
- name: npm ci
uses: salesforcecli/github-workflows/.github/actions/retry@main
uses: salesforcecli/github-workflows/.github/actions/retry@ph/W-23832274-pnpm-stable-promotion

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't make any changes to the actions/retry action, why is the @your-branch needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. The retry action is unchanged, so it should remain pinned to @main. I reverted the unnecessary branch references while retaining branch references only for actions changed by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants